remove unneeded else

public-typescript/adminFees.js

@@ -7,7 +7,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
     let feeCategories = exports.feeCategories;
     delete exports.feeCategories;
     function renderFeeCategories() {
-        var _a, _b, _c, _d, _e, _f, _g, _h, _j;
+        var _a, _b, _c, _d, _e, _f, _g, _h, _j, _k, _l;
         if (feeCategories.length === 0) {
             feeCategoriesContainerElement.innerHTML = `<div class="message is-warning">
         <p class="message-body">There are no available fees.</p>
@@ -70,7 +70,6 @@ Object.defineProperty(exports, "__esModule", { value: true });
                     .querySelector('.button--deleteFeeCategory')
                     .addEventListener('click', confirmDeleteFeeCategory);
             }
-            else {
             for (const fee of feeCategory.fees) {
                 const panelBlockElement = document.createElement('div');
                 panelBlockElement.className = 'panel-block is-block container--fee';
@@ -96,19 +95,25 @@ Object.defineProperty(exports, "__esModule", { value: true });
                                     (((_f = fee.isRequired) !== null && _f !== void 0 ? _f : false)
                                         ? '<span class="tag is-warning">Required</span>'
                                         : '') +
-                                        (fee.occupancyTypeId === undefined
+                                    (((_g = fee.occupancyTypeId) !== null && _g !== void 0 ? _g : -1) === -1
                                         ? ''
                                         : ' <span class="tag has-tooltip-bottom" data-tooltip="' +
                                             los.escapedAliases.Occupancy +
                                             ' Type Filter">' +
-                                                cityssm.escapeHTML((_g = fee.occupancyType) !== null && _g !== void 0 ? _g : '') +
+                                            '<span class="icon is-small"><i class="fas fa-filter" aria-hidden="true"></i></span> ' +
+                                            '<span>' +
+                                            cityssm.escapeHTML((_h = fee.occupancyType) !== null && _h !== void 0 ? _h : '') +
+                                            '</span>' +
                                             '</span>') +
-                                        (fee.lotTypeId === undefined
+                                    (((_j = fee.lotTypeId) !== null && _j !== void 0 ? _j : -1) === -1
                                         ? ''
                                         : ' <span class="tag has-tooltip-bottom" data-tooltip="' +
                                             los.escapedAliases.Lot +
                                             ' Type Filter">' +
-                                                cityssm.escapeHTML((_h = fee.lotType) !== null && _h !== void 0 ? _h : '') +
+                                            '<span class="icon is-small"><i class="fas fa-filter" aria-hidden="true"></i></span> ' +
+                                            '<span>' +
+                                            cityssm.escapeHTML((_k = fee.lotType) !== null && _k !== void 0 ? _k : '') +
+                                            '</span>' +
                                             '</span>') +
                                     '</p>'
                                 : '') +
@@ -133,7 +138,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
                                 '</div>') +
                             ('<div class="column has-text-centered">' +
                                 (fee.includeQuantity
-                                        ? cityssm.escapeHTML((_j = fee.quantityUnit) !== null && _j !== void 0 ? _j : '') +
+                                    ? cityssm.escapeHTML((_l = fee.quantityUnit) !== null && _l !== void 0 ? _l : '') +
                                         '<br />' +
                                         '<small>Quantity</small>'
                                     : '') +
@@ -152,7 +157,6 @@ Object.defineProperty(exports, "__esModule", { value: true });
                 panelBlockElement.querySelector('.button--moveFeeDown').addEventListener('click', moveFee);
                 feeCategoryContainerElement.append(panelBlockElement);
             }
-            }
             feeCategoryContainerElement
                 .querySelector('.button--editFeeCategory')
                 .addEventListener('click', openEditFeeCategory);

public-typescript/adminFees.ts

@@ -95,7 +95,8 @@ declare const bulmaJS: BulmaJS
         feeCategoryContainerElement
           .querySelector('.button--deleteFeeCategory')!
           .addEventListener('click', confirmDeleteFeeCategory)
-      } else {
+      }
+
       for (const fee of feeCategory.fees) {
         const panelBlockElement = document.createElement('div')
 
@@ -125,19 +126,25 @@ declare const bulmaJS: BulmaJS
                 (fee.isRequired ?? false
                   ? '<span class="tag is-warning">Required</span>'
                   : '') +
-                  (fee.occupancyTypeId === undefined
+                ((fee.occupancyTypeId ?? -1) === -1
                   ? ''
                   : ' <span class="tag has-tooltip-bottom" data-tooltip="' +
                     los.escapedAliases.Occupancy +
                     ' Type Filter">' +
+                    '<span class="icon is-small"><i class="fas fa-filter" aria-hidden="true"></i></span> ' +
+                    '<span>' +
                     cityssm.escapeHTML(fee.occupancyType ?? '') +
+                    '</span>' +
                     '</span>') +
-                  (fee.lotTypeId === undefined
+                ((fee.lotTypeId ?? -1) === -1
                   ? ''
                   : ' <span class="tag has-tooltip-bottom" data-tooltip="' +
                     los.escapedAliases.Lot +
                     ' Type Filter">' +
+                    '<span class="icon is-small"><i class="fas fa-filter" aria-hidden="true"></i></span> ' +
+                    '<span>' +
                     cityssm.escapeHTML(fee.lotType ?? '') +
+                    '</span>' +
                     '</span>') +
                 '</p>'
               : '') +
@@ -194,7 +201,6 @@ declare const bulmaJS: BulmaJS
 
         feeCategoryContainerElement.append(panelBlockElement)
       }
-      }
 
       feeCategoryContainerElement
         .querySelector('.button--editFeeCategory')!