fix save when no fields

deepsource-autofix-76c6eb20
Dan Gowans 2022-08-22 16:21:16 -04:00
parent 4090714ace
commit 2347920c44
6 changed files with 8 additions and 8 deletions

View File

@ -4,7 +4,7 @@ interface AddLotOccupancyForm {
lotId: string | number;
occupancyStartDateString: string;
occupancyEndDateString: string;
occupancyTypeFieldIds: string;
occupancyTypeFieldIds?: string;
[lotOccupancyFieldValue_occupancyTypeFieldId: string]: unknown;
}
export declare const addLotOccupancy: (lotOccupancyForm: AddLotOccupancyForm, requestSession: recordTypes.PartialSession) => number;

View File

@ -22,7 +22,7 @@ export const addLotOccupancy = (lotOccupancyForm, requestSession) => {
undefined :
dateTimeFunctions.dateStringToInteger(lotOccupancyForm.occupancyEndDateString)), requestSession.user.userName, rightNowMillis, requestSession.user.userName, rightNowMillis);
const lotOccupancyId = result.lastInsertRowid;
const occupancyTypeFieldIds = lotOccupancyForm.occupancyTypeFieldIds.split(",");
const occupancyTypeFieldIds = (lotOccupancyForm.occupancyTypeFieldIds || "").split(",");
for (const occupancyTypeFieldId of occupancyTypeFieldIds) {
const lotOccupancyFieldValue = lotOccupancyForm["lotOccupancyFieldValue_" + occupancyTypeFieldId];
if (lotOccupancyFieldValue && lotOccupancyFieldValue !== "") {

View File

@ -20,7 +20,7 @@ interface AddLotOccupancyForm {
occupancyStartDateString: string;
occupancyEndDateString: string;
occupancyTypeFieldIds: string;
occupancyTypeFieldIds?: string;
[lotOccupancyFieldValue_occupancyTypeFieldId: string]: unknown;
}
@ -60,7 +60,7 @@ export const addLotOccupancy =
const lotOccupancyId = result.lastInsertRowid as number;
const occupancyTypeFieldIds = lotOccupancyForm.occupancyTypeFieldIds.split(",");
const occupancyTypeFieldIds = (lotOccupancyForm.occupancyTypeFieldIds || "").split(",");
for (const occupancyTypeFieldId of occupancyTypeFieldIds) {

View File

@ -5,7 +5,7 @@ interface UpdateLotOccupancyForm {
lotId: string | number;
occupancyStartDateString: string;
occupancyEndDateString: string;
occupancyTypeFieldIds: string;
occupancyTypeFieldIds?: string;
[lotOccupancyFieldValue_occupancyTypeFieldId: string]: unknown;
}
export declare function updateLotOccupancy(lotOccupancyForm: UpdateLotOccupancyForm, requestSession: recordTypes.PartialSession): boolean;

View File

@ -18,7 +18,7 @@ export function updateLotOccupancy(lotOccupancyForm, requestSession) {
" and recordDelete_timeMillis is null")
.run(lotOccupancyForm.occupancyTypeId, (lotOccupancyForm.lotId === "" ? undefined : lotOccupancyForm.lotId), dateStringToInteger(lotOccupancyForm.occupancyStartDateString), (lotOccupancyForm.occupancyEndDateString === "" ? undefined : dateStringToInteger(lotOccupancyForm.occupancyEndDateString)), requestSession.user.userName, rightNowMillis, lotOccupancyForm.lotOccupancyId);
if (result.changes > 0) {
const occupancyTypeFieldIds = lotOccupancyForm.occupancyTypeFieldIds.split(",");
const occupancyTypeFieldIds = (lotOccupancyForm.occupancyTypeFieldIds || "").split(",");
for (const occupancyTypeFieldId of occupancyTypeFieldIds) {
const lotOccupancyFieldValue = lotOccupancyForm["lotOccupancyFieldValue_" + occupancyTypeFieldId];
if (lotOccupancyFieldValue && lotOccupancyFieldValue !== "") {

View File

@ -26,7 +26,7 @@ interface UpdateLotOccupancyForm {
occupancyStartDateString: string;
occupancyEndDateString: string;
occupancyTypeFieldIds: string;
occupancyTypeFieldIds?: string;
[lotOccupancyFieldValue_occupancyTypeFieldId: string]: unknown;
}
@ -57,7 +57,7 @@ export function updateLotOccupancy(lotOccupancyForm: UpdateLotOccupancyForm, req
if (result.changes > 0) {
const occupancyTypeFieldIds = lotOccupancyForm.occupancyTypeFieldIds.split(",");
const occupancyTypeFieldIds = (lotOccupancyForm.occupancyTypeFieldIds || "").split(",");
for (const occupancyTypeFieldId of occupancyTypeFieldIds) {