steve
/
sunrise-cms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix creating milestone with no type

deepsource-autofix-76c6eb20
Dan Gowans 2023-02-22 14:57:53 -05:00
parent b121aef70f
commit 6dd91877b4
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
helpers/lotOccupancyDB/addWorkOrderMilestone.d.ts vendored
View File

@ -1,7 +1,7 @@
import type * as recordTypes from '../../types/recordTypes'; import type * as recordTypes from '../../types/recordTypes';
interface AddWorkOrderMilestoneForm { interface AddWorkOrderMilestoneForm {
workOrderId: string | number; workOrderId: string | number;
workOrderMilestoneTypeId?: number | string; workOrderMilestoneTypeId: number | string;
workOrderMilestoneDateString: string; workOrderMilestoneDateString: string;
workOrderMilestoneTimeString?: string; workOrderMilestoneTimeString?: string;
workOrderMilestoneDescription: string; workOrderMilestoneDescription: string;

2
helpers/lotOccupancyDB/addWorkOrderMilestone.js
View File

@ -12,7 +12,7 @@ export async function addWorkOrderMilestone(milestoneForm, requestSession) {
recordCreate_userName, recordCreate_timeMillis, recordCreate_userName, recordCreate_timeMillis,
recordUpdate_userName, recordUpdate_timeMillis) recordUpdate_userName, recordUpdate_timeMillis)
values (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)`) values (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)`)
.run(milestoneForm.workOrderId, milestoneForm.workOrderMilestoneTypeId ?? undefined, milestoneForm.workOrderMilestoneDateString === '' .run(milestoneForm.workOrderId, milestoneForm.workOrderMilestoneTypeId === '' ? undefined : milestoneForm.workOrderMilestoneTypeId, milestoneForm.workOrderMilestoneDateString === ''
? 0 ? 0
: dateStringToInteger(milestoneForm.workOrderMilestoneDateString), milestoneForm.workOrderMilestoneTimeString : dateStringToInteger(milestoneForm.workOrderMilestoneDateString), milestoneForm.workOrderMilestoneTimeString
? timeStringToInteger(milestoneForm.workOrderMilestoneTimeString) ? timeStringToInteger(milestoneForm.workOrderMilestoneTimeString)

4
helpers/lotOccupancyDB/addWorkOrderMilestone.ts
View File

@ -11,7 +11,7 @@ import type * as recordTypes from '../../types/recordTypes'
interface AddWorkOrderMilestoneForm { interface AddWorkOrderMilestoneForm {
workOrderId: string | number workOrderId: string | number
workOrderMilestoneTypeId?: number | string workOrderMilestoneTypeId: number | string
workOrderMilestoneDateString: string workOrderMilestoneDateString: string
workOrderMilestoneTimeString?: string workOrderMilestoneTimeString?: string
workOrderMilestoneDescription: string workOrderMilestoneDescription: string
@ -40,7 +40,7 @@ export async function addWorkOrderMilestone(
) )
.run( .run(
milestoneForm.workOrderId, milestoneForm.workOrderId,
milestoneForm.workOrderMilestoneTypeId ?? undefined, milestoneForm.workOrderMilestoneTypeId === '' ? undefined : milestoneForm.workOrderMilestoneTypeId,
milestoneForm.workOrderMilestoneDateString === '' milestoneForm.workOrderMilestoneDateString === ''
? 0 ? 0
: dateStringToInteger(milestoneForm.workOrderMilestoneDateString), : dateStringToInteger(milestoneForm.workOrderMilestoneDateString),