fix accountcode filter

deepsource-autofix-76c6eb20
Dan Gowans 2023-04-18 12:57:03 -04:00
parent d74598c877
commit 75cdf7e036
2 changed files with 21 additions and 21 deletions

View File

@ -7,18 +7,18 @@ if (configFunctions.getProperty('settings.dynamicsGP.integrationIsEnabled')) {
} }
function filterCashReceipt(cashReceipt) { function filterCashReceipt(cashReceipt) {
const accountCodes = configFunctions.getProperty('settings.dynamicsGP.accountCodes'); const accountCodes = configFunctions.getProperty('settings.dynamicsGP.accountCodes');
for (const accountCode of accountCodes) { if (accountCodes.length > 0) {
let found = cashReceipt.details.some((detailRecord) => { for (const detail of cashReceipt.details) {
return detailRecord.accountCode === accountCode; if (accountCodes.includes(detail.accountCode)) {
}); return cashReceipt;
if (!found) { }
found = cashReceipt.distributions.some((distributionRecord) => {
return distributionRecord.accountCode === accountCode;
});
} }
if (!found) { for (const distribution of cashReceipt.distributions) {
return undefined; if (accountCodes.includes(distribution.accountCode)) {
return cashReceipt;
}
} }
return undefined;
} }
return cashReceipt; return cashReceipt;
} }

View File

@ -31,20 +31,20 @@ function filterCashReceipt(
'settings.dynamicsGP.accountCodes' 'settings.dynamicsGP.accountCodes'
) )
for (const accountCode of accountCodes) { if (accountCodes.length > 0) {
let found = cashReceipt.details.some((detailRecord) => { for (const detail of cashReceipt.details) {
return detailRecord.accountCode === accountCode if (accountCodes.includes(detail.accountCode)) {
}) return cashReceipt
}
if (!found) {
found = cashReceipt.distributions.some((distributionRecord) => {
return distributionRecord.accountCode === accountCode
})
} }
if (!found) { for (const distribution of cashReceipt.distributions) {
return undefined if (accountCodes.includes(distribution.accountCode)) {
return cashReceipt
}
} }
return undefined
} }
return cashReceipt return cashReceipt