From ac4ae20f7812359ccaa3068463c445327a33653f Mon Sep 17 00:00:00 2001
From: Dan Gowans <dangowans@users.noreply.github.com>
Date: Fri, 28 Mar 2025 12:43:33 -0400
Subject: [PATCH] linting

---
 public/javascripts/contract.edit.js  |  6 +++---
 public/javascripts/contract.edit.ts  |  6 +++---
 public/javascripts/fees.admin.js     | 12 ++++++------
 public/javascripts/fees.admin.ts     | 12 ++++++------
 public/javascripts/workOrder.edit.js |  4 ++--
 public/javascripts/workOrder.edit.ts |  5 +++--
 6 files changed, 23 insertions(+), 22 deletions(-)

diff --git a/public/javascripts/contract.edit.js b/public/javascripts/contract.edit.js
index 3e9814d3..1445e532 100644
--- a/public/javascripts/contract.edit.js
+++ b/public/javascripts/contract.edit.js
@@ -245,9 +245,9 @@ Object.defineProperty(exports, "__esModule", { value: true });
             setUnsavedChanges();
             burialSiteSelectCloseModalFunction();
         }
-        function selectExistingBurialSite(clickEvent) {
-            clickEvent.preventDefault();
-            const selectedBurialSiteElement = clickEvent.currentTarget;
+        function selectExistingBurialSite(selectClickEvent) {
+            selectClickEvent.preventDefault();
+            const selectedBurialSiteElement = selectClickEvent.currentTarget;
             renderSelectedBurialSiteAndClose(selectedBurialSiteElement.dataset.burialSiteId ?? '', selectedBurialSiteElement.dataset.burialSiteName ?? '');
         }
         function searchBurialSites() {
diff --git a/public/javascripts/contract.edit.ts b/public/javascripts/contract.edit.ts
index 8247818e..d1bd31e4 100644
--- a/public/javascripts/contract.edit.ts
+++ b/public/javascripts/contract.edit.ts
@@ -381,10 +381,10 @@ declare const exports: Record<string, unknown>
       burialSiteSelectCloseModalFunction()
     }
 
-    function selectExistingBurialSite(clickEvent: Event): void {
-      clickEvent.preventDefault()
+    function selectExistingBurialSite(selectClickEvent: Event): void {
+      selectClickEvent.preventDefault()
 
-      const selectedBurialSiteElement = clickEvent.currentTarget as HTMLElement
+      const selectedBurialSiteElement = selectClickEvent.currentTarget as HTMLElement
 
       renderSelectedBurialSiteAndClose(
         selectedBurialSiteElement.dataset.burialSiteId ?? '',
diff --git a/public/javascripts/fees.admin.js b/public/javascripts/fees.admin.js
index f0ad6300..974a69e5 100644
--- a/public/javascripts/fees.admin.js
+++ b/public/javascripts/fees.admin.js
@@ -492,8 +492,8 @@ Object.defineProperty(exports, "__esModule", { value: true });
                 }
             });
         }
-        function confirmDeleteFee(clickEvent) {
-            clickEvent.preventDefault();
+        function confirmDeleteFee(confirmDeleteFeeClickEvent) {
+            confirmDeleteFeeClickEvent.preventDefault();
             function doDelete() {
                 cityssm.postJSON(`${sunrise.urlPrefix}/admin/doDeleteFee`, {
                     feeId
@@ -562,11 +562,11 @@ Object.defineProperty(exports, "__esModule", { value: true });
                 editModalElement = modalElement;
                 modalElement.querySelector('#feeEdit--feeId').value = fee.feeId.toString();
                 const feeCategoryElement = modalElement.querySelector('#feeEdit--feeCategoryId');
-                for (const feeCategory of feeCategories) {
+                for (const feeCategoryOption of feeCategories) {
                     const optionElement = document.createElement('option');
-                    optionElement.value = feeCategory.feeCategoryId.toString();
-                    optionElement.textContent = feeCategory.feeCategory;
-                    if (feeCategory.feeCategoryId === feeCategoryId) {
+                    optionElement.value = feeCategoryOption.feeCategoryId.toString();
+                    optionElement.textContent = feeCategoryOption.feeCategory;
+                    if (feeCategoryOption.feeCategoryId === feeCategoryId) {
                         optionElement.selected = true;
                     }
                     feeCategoryElement.append(optionElement);
diff --git a/public/javascripts/fees.admin.ts b/public/javascripts/fees.admin.ts
index 6ae3a570..c8c05f33 100644
--- a/public/javascripts/fees.admin.ts
+++ b/public/javascripts/fees.admin.ts
@@ -782,8 +782,8 @@ declare const exports: Record<string, unknown>
       )
     }
 
-    function confirmDeleteFee(clickEvent: Event): void {
-      clickEvent.preventDefault()
+    function confirmDeleteFee(confirmDeleteFeeClickEvent: Event): void {
+      confirmDeleteFeeClickEvent.preventDefault()
 
       function doDelete(): void {
         cityssm.postJSON(
@@ -890,12 +890,12 @@ declare const exports: Record<string, unknown>
           '#feeEdit--feeCategoryId'
         ) as HTMLSelectElement
 
-        for (const feeCategory of feeCategories) {
+        for (const feeCategoryOption of feeCategories) {
           const optionElement = document.createElement('option')
-          optionElement.value = feeCategory.feeCategoryId.toString()
-          optionElement.textContent = feeCategory.feeCategory
+          optionElement.value = feeCategoryOption.feeCategoryId.toString()
+          optionElement.textContent = feeCategoryOption.feeCategory
 
-          if (feeCategory.feeCategoryId === feeCategoryId) {
+          if (feeCategoryOption.feeCategoryId === feeCategoryId) {
             optionElement.selected = true
           }
 
diff --git a/public/javascripts/workOrder.edit.js b/public/javascripts/workOrder.edit.js
index e11a9a8b..c50a711d 100644
--- a/public/javascripts/workOrder.edit.js
+++ b/public/javascripts/workOrder.edit.js
@@ -255,7 +255,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
     function deleteMilestone(clickEvent) {
         clickEvent.preventDefault();
         const workOrderMilestoneId = clickEvent.currentTarget.closest('.container--milestone').dataset.workOrderMilestoneId;
-        function doDelete() {
+        function doDeleteMilestone() {
             cityssm.postJSON(`${sunrise.urlPrefix}/workOrders/doDeleteWorkOrderMilestone`, {
                 workOrderMilestoneId,
                 workOrderId
@@ -267,7 +267,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
             contextualColorName: 'warning',
             okButton: {
                 text: 'Yes, Delete Milestone',
-                callbackFunction: doDelete
+                callbackFunction: doDeleteMilestone
             }
         });
     }
diff --git a/public/javascripts/workOrder.edit.ts b/public/javascripts/workOrder.edit.ts
index 978a11a4..2f282742 100644
--- a/public/javascripts/workOrder.edit.ts
+++ b/public/javascripts/workOrder.edit.ts
@@ -398,7 +398,7 @@ declare const exports: Record<string, unknown>
       ) as HTMLElement
     ).dataset.workOrderMilestoneId
 
-    function doDelete(): void {
+    function doDeleteMilestone(): void {
       cityssm.postJSON(
         `${sunrise.urlPrefix}/workOrders/doDeleteWorkOrderMilestone`,
         {
@@ -415,7 +415,7 @@ declare const exports: Record<string, unknown>
       contextualColorName: 'warning',
       okButton: {
         text: 'Yes, Delete Milestone',
-        callbackFunction: doDelete
+        callbackFunction: doDeleteMilestone
       }
     })
   }
@@ -799,6 +799,7 @@ declare const exports: Record<string, unknown>
             conflictingMilestonePanelElement
           )
         },
+        
         onremoved() {
           bulmaJS.toggleHtmlClipped()
           ;(