steve
/
sunrise-cms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

avoid unnecessary query

deepsource-autofix-76c6eb20
Dan Gowans 2023-03-27 13:55:34 -04:00
parent 1e50035474
commit b687e15126
2 changed files with 20 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
helpers/lotOccupancyDB/getWorkOrders.js
View File

@ -115,11 +115,14 @@ export async function getWorkOrders(filters, options, connectedDatabase) {
workOrder.workOrderLotOccupancies = lotOccupancies.lotOccupancies;
}
if (options.includeMilestones ?? false) {
workOrder.workOrderMilestones = await getWorkOrderMilestones({
workOrderId: workOrder.workOrderId
}, {
orderBy: 'date'
}, database);
workOrder.workOrderMilestones =
workOrder.workOrderMilestoneCount === 0
? []
: await getWorkOrderMilestones({
workOrderId: workOrder.workOrderId
}, {
orderBy: 'date'
}, database);
}
}
}

21
helpers/lotOccupancyDB/getWorkOrders.ts
View File

@ -191,15 +191,18 @@ export async function getWorkOrders(
}
if (options.includeMilestones ?? false) {
workOrder.workOrderMilestones = await getWorkOrderMilestones(
{
workOrderId: workOrder.workOrderId
},
{
orderBy: 'date'
},
database
)
workOrder.workOrderMilestones =
workOrder.workOrderMilestoneCount === 0
? []
: await getWorkOrderMilestones(
{
workOrderId: workOrder.workOrderId
},
{
orderBy: 'date'
},
database
)
}
}
}