avoid order number updates

when deleted records are loaded

database/getBurialSiteTypeFields.js

@@ -3,6 +3,7 @@ import { sunriseDB } from '../helpers/database.helpers.js';
 import { updateRecordOrderNumber } from './updateRecordOrderNumber.js';
 export default function getBurialSiteTypeFields(burialSiteTypeId, connectedDatabase) {
     const database = connectedDatabase ?? sqlite(sunriseDB);
+    const updateOrderNumbers = !database.readonly;
     const typeFields = database
         .prepare(`select burialSiteTypeFieldId,
         burialSiteTypeField, fieldType, fieldValues,
@@ -12,6 +13,7 @@ export default function getBurialSiteTypeFields(burialSiteTypeId, connectedDatab
         and burialSiteTypeId = ?
         order by orderNumber, burialSiteTypeField`)
         .all(burialSiteTypeId);
+    if (updateOrderNumbers) {
         let expectedOrderNumber = 0;
         for (const typeField of typeFields) {
             if (typeField.orderNumber !== expectedOrderNumber) {
@@ -20,6 +22,7 @@ export default function getBurialSiteTypeFields(burialSiteTypeId, connectedDatab
             }
             expectedOrderNumber += 1;
         }
+    }
     if (connectedDatabase === undefined) {
         database.close();
     }

database/getBurialSiteTypeFields.ts

@@ -11,6 +11,8 @@ export default function getBurialSiteTypeFields(
 ): BurialSiteTypeField[] {
   const database = connectedDatabase ?? sqlite(sunriseDB)
 
+  const updateOrderNumbers = !database.readonly
+
   const typeFields = database
     .prepare(
       `select burialSiteTypeFieldId,
@@ -23,6 +25,7 @@ export default function getBurialSiteTypeFields(
     )
     .all(burialSiteTypeId) as BurialSiteTypeField[]
 
+  if (updateOrderNumbers) {
     let expectedOrderNumber = 0
 
     for (const typeField of typeFields) {
@@ -39,6 +42,7 @@ export default function getBurialSiteTypeFields(
 
       expectedOrderNumber += 1
     }
+  }
 
   if (connectedDatabase === undefined) {
     database.close()

database/getBurialSiteTypes.js

@@ -4,6 +4,7 @@ import getBurialSiteTypeFields from './getBurialSiteTypeFields.js';
 import { updateRecordOrderNumber } from './updateRecordOrderNumber.js';
 export default function getBurialSiteTypes(includeDeleted = false) {
     const database = sqlite(sunriseDB);
+    const updateOrderNumbers = !database.readonly && !includeDeleted;
     const burialSiteTypes = database
         .prepare(`select burialSiteTypeId, burialSiteType, orderNumber
         from BurialSiteTypes
@@ -13,7 +14,7 @@ export default function getBurialSiteTypes(includeDeleted = false) {
     let expectedOrderNumber = -1;
     for (const burialSiteType of burialSiteTypes) {
         expectedOrderNumber += 1;
-        if (burialSiteType.orderNumber !== expectedOrderNumber) {
+        if (updateOrderNumbers && burialSiteType.orderNumber !== expectedOrderNumber) {
             updateRecordOrderNumber('BurialSiteTypes', burialSiteType.burialSiteTypeId, expectedOrderNumber, database);
             burialSiteType.orderNumber = expectedOrderNumber;
         }

database/getBurialSiteTypes.ts

@@ -11,6 +11,8 @@ export default function getBurialSiteTypes(
 ): BurialSiteType[] {
   const database = sqlite(sunriseDB)
 
+  const updateOrderNumbers = !database.readonly && !includeDeleted
+
   const burialSiteTypes = database
     .prepare(
       `select burialSiteTypeId, burialSiteType, orderNumber
@@ -25,7 +27,7 @@ export default function getBurialSiteTypes(
   for (const burialSiteType of burialSiteTypes) {
     expectedOrderNumber += 1
 
-    if (burialSiteType.orderNumber !== expectedOrderNumber) {
+    if (updateOrderNumbers && burialSiteType.orderNumber !== expectedOrderNumber) {
       updateRecordOrderNumber(
         'BurialSiteTypes',
         burialSiteType.burialSiteTypeId,

database/getCommittalTypes.js

@@ -3,12 +3,14 @@ import { sunriseDB } from '../helpers/database.helpers.js';
 import { updateRecordOrderNumber } from './updateRecordOrderNumber.js';
 export default function getCommittalTypes(includeDeleted = false) {
     const database = sqlite(sunriseDB);
+    const updateOrderNumbers = !database.readonly && !includeDeleted;
     const committalTypes = database
         .prepare(`select committalTypeId, committalTypeKey, committalType, orderNumber
         from CommittalTypes
         ${includeDeleted ? '' : ' where recordDelete_timeMillis is null '}
         order by orderNumber, committalType, committalTypeId`)
         .all();
+    if (updateOrderNumbers) {
         let expectedOrderNumber = -1;
         for (const committalType of committalTypes) {
             expectedOrderNumber += 1;
@@ -17,6 +19,7 @@ export default function getCommittalTypes(includeDeleted = false) {
                 committalType.orderNumber = expectedOrderNumber;
             }
         }
+    }
     database.close();
     return committalTypes;
 }

database/getCommittalTypes.ts

@@ -10,6 +10,8 @@ export default function getCommittalTypes(
 ): CommittalType[] {
   const database = sqlite(sunriseDB)
 
+  const updateOrderNumbers = !database.readonly && !includeDeleted
+
   const committalTypes = database
     .prepare(
       `select committalTypeId, committalTypeKey, committalType, orderNumber
@@ -19,6 +21,7 @@ export default function getCommittalTypes(
     )
     .all() as CommittalType[]
 
+  if (updateOrderNumbers) {
     let expectedOrderNumber = -1
 
     for (const committalType of committalTypes) {
@@ -35,6 +38,7 @@ export default function getCommittalTypes(
         committalType.orderNumber = expectedOrderNumber
       }
     }
+  }
 
   database.close()
 

database/getContractTypeFields.js

@@ -3,6 +3,7 @@ import { sunriseDB } from '../helpers/database.helpers.js';
 import { updateRecordOrderNumber } from './updateRecordOrderNumber.js';
 export default function getContractTypeFields(contractTypeId, connectedDatabase) {
     const database = connectedDatabase ?? sqlite(sunriseDB);
+    const updateOrderNumbers = !database.readonly && contractTypeId !== undefined;
     const sqlParameters = [];
     if ((contractTypeId ?? -1) !== -1) {
         sqlParameters.push(contractTypeId);
@@ -17,6 +18,7 @@ export default function getContractTypeFields(contractTypeId, connectedDatabase)
         : ' and contractTypeId = ?'}
         order by orderNumber, contractTypeField`)
         .all(sqlParameters);
+    if (updateOrderNumbers) {
         let expectedOrderNumber = 0;
         for (const contractTypeField of contractTypeFields) {
             if (contractTypeField.orderNumber !== expectedOrderNumber) {
@@ -25,6 +27,7 @@ export default function getContractTypeFields(contractTypeId, connectedDatabase)
             }
             expectedOrderNumber += 1;
         }
+    }
     if (connectedDatabase === undefined) {
         database.close();
     }

database/getContractTypeFields.ts

@@ -11,6 +11,8 @@ export default function getContractTypeFields(
 ): ContractTypeField[] {
   const database = connectedDatabase ?? sqlite(sunriseDB)
 
+  const updateOrderNumbers = !database.readonly && contractTypeId !== undefined
+
   const sqlParameters: unknown[] = []
 
   if ((contractTypeId ?? -1) !== -1) {
@@ -32,6 +34,7 @@ export default function getContractTypeFields(
     )
     .all(sqlParameters) as ContractTypeField[]
 
+  if (updateOrderNumbers) {
     let expectedOrderNumber = 0
 
     for (const contractTypeField of contractTypeFields) {
@@ -48,6 +51,7 @@ export default function getContractTypeFields(
 
       expectedOrderNumber += 1
     }
+  }
 
   if (connectedDatabase === undefined) {
     database.close()

database/getFeeCategories.js

@@ -3,8 +3,10 @@ import { sunriseDB } from '../helpers/database.helpers.js';
 import getFees from './getFees.js';
 import { updateRecordOrderNumber } from './updateRecordOrderNumber.js';
 export default function getFeeCategories(filters, options, connectedDatabase) {
-    const updateOrderNumbers = !(filters.burialSiteTypeId || filters.contractTypeId) && options.includeFees;
+    const database = connectedDatabase ?? sqlite(sunriseDB);
-    const database = sqlite(sunriseDB);
+    const updateOrderNumbers = !database.readonly &&
+        !(filters.burialSiteTypeId || filters.contractTypeId) &&
+        options.includeFees;
     let sqlWhereClause = ' where recordDelete_timeMillis is null';
     const sqlParameters = [];
     if ((filters.contractTypeId ?? '') !== '') {
@@ -18,7 +20,7 @@ export default function getFeeCategories(filters, options, connectedDatabase) {
         sqlParameters.push(filters.burialSiteTypeId);
     }
     if ((filters.feeCategoryId ?? '') !== '') {
-        sqlWhereClause += ` and feeCategoryId = ?`;
+        sqlWhereClause += ' and feeCategoryId = ?';
         sqlParameters.push(filters.feeCategoryId);
     }
     const feeCategories = database

database/getFeeCategories.ts

@@ -21,10 +21,12 @@ export default function getFeeCategories(
   options: GetFeeCategoriesOptions,
   connectedDatabase?: sqlite.Database
 ): FeeCategory[] {
-  const updateOrderNumbers =
+  const database = connectedDatabase ?? sqlite(sunriseDB)
-    !(filters.burialSiteTypeId || filters.contractTypeId) && options.includeFees
 
-  const database = sqlite(sunriseDB)
+  const updateOrderNumbers =
+    !database.readonly &&
+    !(filters.burialSiteTypeId || filters.contractTypeId) &&
+    options.includeFees
 
   let sqlWhereClause = ' where recordDelete_timeMillis is null'
 
@@ -45,7 +47,7 @@ export default function getFeeCategories(
   }
 
   if ((filters.feeCategoryId ?? '') !== '') {
-    sqlWhereClause += ` and feeCategoryId = ?`
+    sqlWhereClause += ' and feeCategoryId = ?'
     sqlParameters.push(filters.feeCategoryId)
   }
 

database/getFees.js

@@ -2,8 +2,9 @@ import sqlite from 'better-sqlite3';
 import { sunriseDB } from '../helpers/database.helpers.js';
 import { updateRecordOrderNumber } from './updateRecordOrderNumber.js';
 export default function getFees(feeCategoryId, additionalFilters, connectedDatabase) {
-    const updateOrderNumbers = !(additionalFilters.burialSiteTypeId || additionalFilters.contractTypeId);
     const database = connectedDatabase ?? sqlite(sunriseDB);
+    const updateOrderNumbers = !database.readonly &&
+        !(additionalFilters.burialSiteTypeId || additionalFilters.contractTypeId);
     let sqlWhereClause = ' where f.recordDelete_timeMillis is null and f.feeCategoryId = ?';
     const sqlParameters = [feeCategoryId];
     if (additionalFilters.contractTypeId) {

database/getFees.ts

@@ -15,12 +15,12 @@ export default function getFees(
   additionalFilters: GetFeesFilters,
   connectedDatabase?: sqlite.Database
 ): Fee[] {
-  const updateOrderNumbers = !(
-    additionalFilters.burialSiteTypeId || additionalFilters.contractTypeId
-  )
-
   const database = connectedDatabase ?? sqlite(sunriseDB)
 
+  const updateOrderNumbers =
+    !database.readonly &&
+    !(additionalFilters.burialSiteTypeId || additionalFilters.contractTypeId)
+
   let sqlWhereClause =
     ' where f.recordDelete_timeMillis is null and f.feeCategoryId = ?'
 

database/getIntermentContainerTypes.js

@@ -3,6 +3,7 @@ import { sunriseDB } from '../helpers/database.helpers.js';
 import { updateRecordOrderNumber } from './updateRecordOrderNumber.js';
 export default function getIntermentContainerTypes(includeDeleted = false) {
     const database = sqlite(sunriseDB);
+    const updateOrderNumbers = !database.readonly && !includeDeleted;
     const containerTypes = database
         .prepare(`select intermentContainerTypeId, intermentContainerType, intermentContainerTypeKey,
         isCremationType, orderNumber
@@ -10,6 +11,7 @@ export default function getIntermentContainerTypes(includeDeleted = false) {
         ${includeDeleted ? '' : ' where recordDelete_timeMillis is null '}
         order by isCremationType, orderNumber, intermentContainerType, intermentContainerTypeId`)
         .all();
+    if (updateOrderNumbers) {
         let expectedOrderNumber = -1;
         for (const containerType of containerTypes) {
             expectedOrderNumber += 1;
@@ -18,6 +20,7 @@ export default function getIntermentContainerTypes(includeDeleted = false) {
                 containerType.orderNumber = expectedOrderNumber;
             }
         }
+    }
     database.close();
     return containerTypes;
 }

database/getIntermentContainerTypes.ts

@@ -10,6 +10,8 @@ export default function getIntermentContainerTypes(
 ): IntermentContainerType[] {
   const database = sqlite(sunriseDB)
 
+  const updateOrderNumbers = !database.readonly && !includeDeleted
+
   const containerTypes = database
     .prepare(
       `select intermentContainerTypeId, intermentContainerType, intermentContainerTypeKey,
@@ -20,6 +22,7 @@ export default function getIntermentContainerTypes(
     )
     .all() as IntermentContainerType[]
 
+  if (updateOrderNumbers) {
     let expectedOrderNumber = -1
 
     for (const containerType of containerTypes) {
@@ -36,6 +39,7 @@ export default function getIntermentContainerTypes(
         containerType.orderNumber = expectedOrderNumber
       }
     }
+  }
 
   database.close()